-
Notifications
You must be signed in to change notification settings - Fork 2
release 0.13.0 #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
release 0.13.0 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aw for consistency
…est for untracked errors
…resholdForClassicOperation
…nit test for untracked errors
…in string helper functions
…uthEntry functions for SorobanAuthorizationEntry handling
* feat(wip) add sac client * feat(wip): implement SAC error handling and contract methods * feat: rename SEP-11 asset functions and types to StellarAssetCanonicalString * feat: add unit tests for StellarAssetContract deployment error handling - Implement unit tests for StellarAssetContract's deploy method to ensure proper error handling for various scenarios, including non-SIMULATION_FAILED errors and malformed simulation responses. - Refactor asset-related imports to use StellarAssetCanonicalString instead of SEP11Asset across multiple event standards. - Update contract integration tests to instantiate Contract using the new constructor method. - Remove unused Asset import from contract error handling. - Clean up commented-out code related to asset wrapping in contract integration tests. * fix: correct import paths in unit tests for StellarAsset and ScVal * test: add missing tests for MintEvent and TransferEvent validation scenarios * chore: update version to 0.11.0 in deno.json
Co-authored-by: Copilot <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 99.01% 99.10% +0.09%
==========================================
Files 144 147 +3
Lines 7175 7285 +110
Branches 732 733 +1
==========================================
+ Hits 7104 7220 +116
+ Misses 71 65 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors various type guard and signer-related utilities throughout the codebase for improved clarity and maintainability. The main changes include replacing the
TransactionSignertype with a more generalSignertype, consolidating and renaming type guard functions from theverifiersdirectory to a newtype-guardsdirectory, and updating all relevant imports and usages. This update also introduces a new utility for checking if an object has a function property, and removes legacy code.Type guard and signer refactoring:
TransactionSignerwith the new, more generalSignertype in files such ascore/account/native/index.ts,core/account/native/types.ts,core/common/types/transaction-config/types.ts, and related test and implementation files. [1] [2] [3] [4] [5] [6] [7] [8] [9]isSignertype guard incore/common/type-guards/is-signer.tsto robustly check forSignerobjects, and removed the legacyis-transaction-signer.ts. [1] [2]Type guard utilities consolidation:
core/common/verifiers/tocore/common/type-guards/, updated their names and imports, and removed the oldverifiersexports. [1] [2] [3] [4] [5]type-guardslocation and naming. [1] [2] [3]Utility additions:
hasFunctionincore/common/type-guards/has-function.tsto check if an object has a specified function property.isDefinedutility to check for bothundefinedandnullvalues.Versioning:
0.13.0incore/deno.jsonto reflect these breaking changes.